On Thu, Jun 6, 2013 at 9:00 PM, John McCall <[email protected]> wrote:
> +typedef llvm::ArrayRef<const CXXRecordDecl *> ClassArrayRef; > + > > Don't do this. It's really not saving you anything, and it makes the API > randomly harder to understand. > I blame Timur. :) > --- lib/CodeGen/CGVTables.cpp > +++ lib/CodeGen/CGVTables.cpp > > Is this benefitting from being in this file? I actually want to eliminate > CGVTables in the long run and replace it with minimal-surface-area > builder classes specific to, and invoked by, the ABI classes. If you > can do something more along those lines, I'd be happier. Think > smaller, more single-purpose implementation files, with CGM-level > state kept in the ABI class. > So, something along the lines of CodeGen/MicrosoftVBTables.cpp? > I'm happy that you seem to have figured out the disambiguation logic. > That part all looks fine, although I haven't really reviewed your > algorithm. > > John. >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
