On Mon, Jun 10, 2013 at 4:51 PM, Fariborz Jahanian <[email protected]> wrote: > > +def warn_missing_atsign_prefix : Warning< > + "string literal must be prefixed by '@' ">, > InGroup<ObjCLiteralMissingAtSign>;
Shouldn't this say "NSString literal", not "string literal"? Objective-C has the same string literals as C and C++, and they don't need to be prefixed by '@'. I feel like overriding the term "string literal" in this message to refer specifically to NSString literals is actually more confusing than it is helpful. (Personally, I liked the old diagnostic. It helpfully showed the formal and actual parameter types so you could see how they mismatched and how to fix it. This new warning is basically just saying "Hey. Add an '@' here. Trust me.") -Arthur _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
