Thanks your review! Hi Richard, I guess lib/Sema is owned by you. Could you help commit if ok? Or who should I ask to help review and commit?
Thanks! 2013/6/25 下午10:10 於 "Rafael Espíndola" <[email protected]> ��道： > LGTM > > On 24 June 2013 21:35, WenHan Gu (谷汶翰) <[email protected]> wrote: > > Merge into existing testcase. Thanks! > > > > 2013/6/25 上午3:34 於 "Rafael Espíndola" <[email protected]> ��道： > > > >> The test fails, since clang with -verify is looking for diagnostics to > >> match. You need to add expected-no-diagnostics to the test or if > >> possible merge the test with an existing file to reduce the number of > >> distinct tests that get run during a check-clang invocation. > >> > >> On 24 June 2013 14:34, WenHan Gu (谷汶翰) <[email protected]> wrote: > >> > Attached. > >> > Sorry for inconvenience. > >> > > >> > 2013/6/24 下午10:20 於 "Rafael Espíndola" <[email protected]> > ��道： > >> > > >> >> Your second patch is a link to google docs and it is failing to > >> >> download > >> >> for me. Would you mind just attaching the patch? > >> >> > >> >> Thanks, > >> >> Rafael > >> >> > >> > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
