On Mon, Jul 15, 2013 at 8:37 AM, Reid Kleckner <[email protected]> wrote:
> > Is it possible for the buffer to only contain a single byte? > > MemoryBuffer makes sure the file is null terminated, but the empty file is > still a corner case where we have a single byte buffer over read. I should > fix it. > > This is growing enough corner cases that I'm reconsidering my decision to > not put this in llvm/lib/Support/ConvertUTF8Wrappers.cc. I didn't like the > idea of loading an entire response file (usually large) into a std::string, > but the reality is that we're building a set of strings anyway. > Considering that lld will need response file support, I should do this differently.
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
