While working on something else I stumbled on a use of sys::fs::copy_file in FileRemapper::overwriteOriginal. Given that it looks like the function wants to move temporary files over originals, it should probably be using rename, no?
I wrote the attached use_rename.patch, but then noticed that no test touches this code path. In fact, the attached dead.patch causes no failures :-( Is the code actually dead? If not, any ideas for a testcase that would execute it? If it is not dead, should it be using rename? Cheers, Rafael
use_rename.patch
Description: Binary data
dead.patch
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
