I've applied (without ExtVectorType, Mode or OpenCLImageAccess changes) in r186598. Those other three may be covered by a different patch I submitted earlier adding support for encoding type attributes.
~Aaron On Thu, Jul 18, 2013 at 2:46 PM, Eli Friedman <[email protected]> wrote: > On Thu, Jul 18, 2013 at 11:29 AM, Dean Sutherland <[email protected]> > wrote: >> Change declarations of 8 attributes to InheritableAttr from Attr. All eight >> are already processed as inheritable attributes. This change makes their >> declaration match the processing. This is clean-up in preparation for >> tablegen improvements to reduce redundancy in SemaDeclAttr and friends. No >> functional changes intended. >> >> The effected attributes are: >> OpenCLKernel >> OpenCLImageAccess >> ExtVectorType >> Mode >> ObjCPreciseLifetime >> ObjCReturnsInnerPointer >> ObjCRootClass >> ObjCOwnership > > Hmm... > > For ExtVectorType, Mode, and OpenCLImageAccess, I'm not sure it makes > sense to say they're inherited: processTypeAttrs in SemaType.cpp > always handles them. > > The others are fine. (You don't need to get confirmation from the > people who wrote them.) > > -Eli > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
