Thanks! r186720.
On Fri, Jul 19, 2013 at 11:55 AM, Reid Kleckner <[email protected]> wrote: > LGTM > > > On Fri, Jul 19, 2013 at 2:51 PM, Hans Wennborg <[email protected]> wrote: >> >> On Fri, Jul 19, 2013 at 11:39 AM, Reid Kleckner <[email protected]> wrote: >> > + /// Whether the drvier was invoked as a C++ compiler >> > + /// (e.g. clang++ or clang-cl). >> > + bool CCCIsCXX() const { return Mode == GXXMode || Mode == CLMode; } >> > >> > Looks good, but what needs this? My understanding is that all of clang, >> > cl, >> > and gcc can be invoked on .c or .cpp files and they will auto-detect the >> > language from the extension. The main behavior difference is whether to >> > link the standard C++ library. >> >> I think the mode overrides the auto-detection though, e.g. "clang++ >> a.c" will treat the file as c++ (and warn about it). >> >> Checking for CLMode here probably doesn't make sense actually, I'll revert >> it. >> >> New patch attached. >> >> - Hans >> >> > On Fri, Jul 19, 2013 at 2:31 PM, Hans Wennborg <[email protected]> >> > wrote: >> >> >> >> Hi all, >> >> >> >> The attached patch adds a cl.exe compatible mode to the driver. It >> >> doesn't actually do anything yet, but the plan is to make it accept >> >> cl.exe style command line flags as discussed in [1]. >> >> >> >> Please take a look! >> >> >> >> Thanks, >> >> Hans >> >> >> >> [1]. http://lists.cs.uiuc.edu/pipermail/cfe-dev/2013-June/030439.html > > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
