I've committed a change based on your patch in r186803. A few changes relative to your patch: * We preserve the virtual base initializer in a constructor for an abstract class. We'll never use it, but this is important for source fidelity. We also give a warning on this case (disabled by default, since most compilers do not yet implement DR257). * The handling of implicit deletion of special members was incorrect. The standard has a defect here, which I've reported (there is no special case for virtual bases of abstract classes in the implicit deletion rules), but the exception should only affect constructors. For an assignment operator or a destructor, the virtual base should still be checked.
Thanks! On Fri, Jul 19, 2013 at 3:15 PM, Maurice Bos <[email protected]> wrote: > Hi, > > Attached is a patch to fix http://llvm.org/bugs/show_bug.cgi?id=16659. > > Kind regards, > -Maurice Bos- > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
