On 07/21/2013 09:15 PM, Richard Smith wrote:
On Sun, Jul 21, 2013 at 11:31 AM, Enea Zaffanella
<[email protected] <mailto:[email protected]>> wrote:
On 07/12/2013 10:51 PM, Enea Zaffanella wrote:
On 07/12/2013 08:53 PM, Eli Friedman wrote:
> Please split this patch. It's practically unreadable as-is.
>
> -Eli
Here is the third (and last) part of the patch. Actually ... this is a
different patch wet the one proposed before.
In UnresolvedUsingTypenameDecl nodes, the UsingLocation field is not
initialized in the constructor, nor it is ever accessed, e.g., when
(de-)serializing the node. The start location for the source range is
obtained by querying the TypeDecl base class. Hence, the patch simply
removes this apparently useless source location field.
OK to commit?
Enea.
Index: include/clang/AST/DeclCXX.h
===================================================================
--- include/clang/AST/DeclCXX.h (revision 186817)
+++ include/clang/AST/DeclCXX.h (working copy)
@@ -2952,9 +2952,6 @@
class UnresolvedUsingTypenameDecl : public TypeDecl {
virtual void anchor();
- /// \brief The source location of the 'using' keyword
- SourceLocation UsingLocation;
-
/// \brief The source location of the 'typename' keyword
SourceLocation TypenameLocation;
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
