On 07/22/2013 06:10 PM, NAKAMURA Takumi wrote:
Tweaked in r186833. I am afraid if it were redundant...
As a matter of fact, my patch was overshooting C89 6.5.7 p3:
the warning should only be emitted when the initalizer is an
InitListExpr node.
Sorry for the troubles caused, I will commit the fix asap.
Enea.
2013/7/23 Eli Friedman <[email protected]>:
On Mon, Jul 22, 2013 at 6:29 AM, Enea Zaffanella <[email protected]> wrote:
On 07/22/2013 02:28 PM, NAKAMURA Takumi wrote:
It brings bunch of warnings in c-index-test.c with c89 mode.
Shall we tweak c-index-test.c as c89-compliant, or should I suppress
warnings with -Wno-c99-extensions in my builders?
As for me, no strong opinions in this respect ...
I guess the question to be answered is whether or not c-index-test.c was
originally meant to be c89 compliant.
It's not really meant to be C89-compliant... but as a practical
matter, if we disable the warnings, it becomes much easier to break
compilation with MSVC.
-Eli
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
