Can do. Assuming those changes are made, LGTY? ~Aaron
On Mon, Jul 22, 2013 at 5:39 PM, Eli Friedman <[email protected]> wrote: > On Mon, Jul 22, 2013 at 12:34 PM, Aaron Ballman <[email protected]> > wrote: >> This patch consolidates several attribute argument diagnostics into a >> single, selectable diagnostic. This makes the diagnostic more >> consistent as well. Minor functional changes caused two test cases to >> be updated. > > Please use an enum for the argument types. > > If if isn't too inconvenient, please strip the _'s from the attribute > names; they're useless noise. > > -Eli _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
