Mm...seems a bit weird to index the attribute parameters when there's only one. Can we special case that with a %plural?
Jordan On Jul 23, 2013, at 8:47 , Aaron Ballman <[email protected]> wrote: > The err_attribute_not_string error seems like it can be subsumed by > the err_attribute_argument_n_type diagnostic; the main difference > between the two being that the latter specifies an argument position > while the former does not. > > This patch performs the replacement, but I wanted to make sure it was > acceptable. If the consensus is that this is fine, I will commit a > separate patch that does the same for err_attribute_argument_not_int. > > ~Aaron
attr_str.patch
Description: Binary data
> _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
