On Jul 23, 2013, at 11:56 AM, Marshall Clow <[email protected]> wrote:

> On Jul 22, 2013, at 2:09 PM, Marshall Clow <[email protected]> wrote:
> 
>> Implements the "s" suffix for chrono literals as called for in N3642 + tests.

Thanks Marshall!

Just a few nits:

   test/utilities/time/chrono.literals.pass.cpp

should be:

   
test/utilities/time/time.duration/time.duration.literals/chrono.literals.pass.cpp

I've added a comment concerning the inline on namespace literals as we did for 
<string>.

I've added static_cast for each of the integral duration udl's along the lines 
of:

        constexpr chrono::hours operator"" h(unsigned long long __h)
        {
                return chrono::hours(static_cast<chrono::hours::rep>(__h));
        }

Patch enclosed for this.

Please commit with these changes.

Thanks,
Howard

Attachment: chrono_literals.patch
Description: Binary data

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to