I was thinking more along the lines of a unit test instead of relying on system stack limits, but am not too strongly tied to that.
~Aaron On Jul 24, 2013 10:13 PM, "Rafael Espíndola" <[email protected]> wrote: > On 24 July 2013 15:34, Aaron Ballman <[email protected]> wrote: > > Patch LGTM; is there a way that we could add a test to ensure > > diagnoseOverflow doesn't break again (since this is fixing a > > regression)? > > Thanks, I committed it as r187097. > > I found this by enabling pipefail and running the tests on a windows > vm. I hope to be able to enable it really soon now. Once that is in, > parser_overflow.c should fail on any systems that goes out of stack > space. I guess we could explicitly run ulimit in the test, but I am > not sure that adds a lot of value. > > > ~Aaron > > Cheers, > Rafael >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
