Re: [PATCH] Bug 14984 - Implement __attribute__((ms_abi))

[Charles Davis]

On Jul 12, 2013, at 5:48 AM, Reid Kleckner wrote: On Tue, Jun 18, 2013 at 6:25 AM, Benno Rice <be...@freebsd.org> wrote: On 12/06/2013, at 10:40 PM, Reid Kleckner <r...@google.com> wrote: On Wed, Jun 12, 2013 at 7:13 AM, Charles Davis <cdavi...@gmail.com> wrote: You mean like in my patch here: http://llvm-reviews.chandlerc.com/D729 ? Yeah, that looks good to me.  :) From the docs, it seems attr(ms_abi) just maps to x86_64_win64cc and x86_stdcallcc depending on the architecture: http://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html#index-g_t_0040code_007bsysv_005fabi_007d-attribute-2670 gcc also appears to support a sysv_abi attribute, which lets you use the sysv CCs when targeting Windows. So what's in the way of this being committed? Is there anything I can do that would accelerate things? Benno, Charles added explicit sysv and win64 CCs to LLVM.  Feel free to update your clang patch based on that and resend.  I can wait no longer... I've taken the Clang side of Benno's patch, updated it against my LLVM patch, and rebased it against trunk. I also added the complementary sysv_abi attribute. OK to commit? Chip

0001-Add-ms_abi-and-sysv_abi-attribute-handling.patch
Description: Binary data

_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits