On Monday 01 of July 2013, Eli Friedman wrote: > On Sat, Jun 29, 2013 at 11:23 PM, Lubos Lunak <[email protected]> wrote: > > Hello, > > > > could somebody please review and commit the atached patch for pr12463? > > Thank > > you. > > > > + bool InMacro = LHS.get()->getLocStart().isMacroID() || > > + RHS.get()->getLocStart().isMacroID(); > > Why not just check the source location of the operator itself? It seems > like we want to diagnose "MYMACRO1 == MYMACRO2".
I don't know, because that's not my code. If you look at the patch, this is just moved out of the first if(), in order to prevent it from applying to all the cases. So maybe it's a good question, but it's not really part of this issue. -- Lubos Lunak [email protected] _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
