LGTM
================
Comment at: lib/Driver/WindowsToolChain.cpp:351
@@ +350,3 @@
+ break;
+ case options::OPT__SLASH_W1:
+ Alias = "all";
----------------
Is it necessary to have this custom handling for aliased options? I was hoping
to limit the custom handling to things that can't be expressed as simple
aliases like -W0.
================
Comment at: include/clang/Driver/Options.td:176
@@ -173,3 +175,3 @@
-def _HASH_HASH_HASH : Flag<["-"], "###">, Flags<[DriverOption]>,
+def _HASH_HASH_HASH : Flag<["-"], "###">, Flags<[DriverOption, CLOption]>,
HelpText<"Print the commands to run for this compilation">;
----------------
Probably worth a TODO that in the long run this should be ClangOption instead
of CLOption.
http://llvm-reviews.chandlerc.com/D1232
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
