LGTM
================ Comment at: lib/AST/MicrosoftMangle.cpp:905 @@ +904,3 @@ + mangleType(cast<TagDecl>( + TA.getAsTemplate().getAsTemplateDecl()->getTemplatedDecl())); + break; ---------------- Reid Kleckner wrote: > The Itanium mangler tries to unpack the TemplateName a bit, but many of those > cases look unreachable. Can you issue an error diagnostic if > getAsTemplatedDecl() returns null? Based on discussion in person, it looks like the cases where getAsTemplateDecl() returns null may be dead code in the Itanium mangler. I'm OK with this as is. http://llvm-reviews.chandlerc.com/D1285 BRANCH PR16789 ARCANIST PROJECT clang _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
