LGTM
================
Comment at: lib/Driver/Driver.cpp:1620
@@ +1619,3 @@
+ Filename.append(".");
+ // FIXME: For clang-cl, we want .obj rather than .o for object files.
+ Filename.append(types::getTypeTempSuffix(types::TY_Object));
----------------
Hans Wennborg wrote:
> Reid Kleckner wrote:
> > We're already dominated by a check for /Fo, which implies clang-cl mode, so
> > I'd just hardcode this to append(".obj") and get this right on the first
> > commit. No need to go back and change the test.
> Yes, but clang-cl mode doesn't necessarily imply /Fo. It would be weird if we
> produced .obj files with /Fo and .o otherwise.
>
> I think it might be better to fix this in a separate patch.
OK, sounds good.
http://llvm-reviews.chandlerc.com/D1302
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
