On Aug 7, 2013, at 6:14 PM, Marshall Clow <[email protected]> wrote:

> On Aug 7, 2013, at 12:08 PM, Howard Hinnant <[email protected]> wrote:
> 
>> On Aug 6, 2013, at 2:39 PM, Marshall Clow <[email protected]> wrote:
>> 
>>> The existing implementations seem to work, so I just added some tests.
>> 
>> Your tests are passing by accident.  __tree_iterator and 
>> __tree_const_iterator in <__tree> need treatment for their default actor.
> 
> Ok. So I fixed that
> 
>>> The general iterator tests for <map> appeared to be missing, so I added 
>>> that, too.
>> 
>> Thanks, but this is covered in map/map.access/iterator.pass.cpp.
> 
> Moved them.
> 
> And I made the __tree_const_iterator () constructor noexcept 
> 
> Revised patch attached.

Looks great, thanks!  Please commit.

Howard

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to