On 09.08.2013, at 05:02, Richard Smith <[email protected]> wrote:
> On Thu, Aug 8, 2013 at 4:08 AM, Benjamin Kramer <[email protected]> > wrote: > Author: d0k > Date: Thu Aug 8 06:08:26 2013 > New Revision: 187975 > > URL: http://llvm.org/viewvc/llvm-project?rev=187975&view=rev > Log: > Remove unused variable. No functionality change. > > Modified: > cfe/trunk/lib/Sema/SemaChecking.cpp > > Modified: cfe/trunk/lib/Sema/SemaChecking.cpp > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaChecking.cpp?rev=187975&r1=187974&r2=187975&view=diff > ============================================================================== > --- cfe/trunk/lib/Sema/SemaChecking.cpp (original) > +++ cfe/trunk/lib/Sema/SemaChecking.cpp Thu Aug 8 06:08:26 2013 > @@ -714,17 +714,15 @@ void Sema::checkCall(NamedDecl *FDecl, > return; > > // Printf and scanf checking. > - bool HandledFormatString = false; > llvm::SmallBitVector CheckedVarArgs; > if (FDecl) { > + CheckedVarArgs.resize(Args.size()); > > We were deliberately not doing this if there are no FormatAttrs on the > function. Makes sense, I was just LICM'ing the call here. Put it back in r188063 with a comment. - Ben > > for (specific_attr_iterator<FormatAttr> > - I = FDecl->specific_attr_begin<FormatAttr>(), > - E = FDecl->specific_attr_end<FormatAttr>(); I != E ; ++I) { > - CheckedVarArgs.resize(Args.size()); > - if (CheckFormatArguments(*I, Args, IsMemberFunction, CallType, Loc, > - Range, CheckedVarArgs)) > - HandledFormatString = true; > - } > + I = FDecl->specific_attr_begin<FormatAttr>(), > + E = FDecl->specific_attr_end<FormatAttr>(); > + I != E; ++I) > + CheckFormatArguments(*I, Args, IsMemberFunction, CallType, Loc, Range, > + CheckedVarArgs); > } > > // Refuse POD arguments that weren't caught by the format string > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
