Hi John, first, I'd be eternally thankful if you submitted patches to Tooling via phabricator (http://llvm.org/docs/Phabricator.html) :)
Second, I'm not yet convinced this patch is the right direction. I'm trying to understand what you're doing: 1. when running a tool over code, I'd assume you don't need to change the include file arguments 2. after run modularize, if I understand you correctly, the header search paths are now not correct any more - this looks to me like it needs build system support, rather than trying to work around this with the include paths Cheers, /Manuel On Mon, Aug 12, 2013 at 6:16 AM, Thompson, John < [email protected]> wrote: > This patch adds an input file name parameter to ArgumentAdjuster’s > Adjust function in Tooling, in order to allow support of changes to a > compile’s arguments based on the file name.**** > > ** ** > > I’m in a testing phase for a new feature for modularize which allows you > to add dependencies to the header files in the input header list. In using > modularize for a real-world set of headers, I found that some headers > needed other headers to be included first, as opposed to including them > themselves or relying on a master header to include the subset of headers > in the right order. With this patch, I can create an ArgumentAdjuster > derivation that’s given a map with the dependencies keyed on the file name, > and have the Adjust function look up the dependencies using the input file > name and then add -include options to first include the depended-on > headers. This seemed easier than other changes or derivations that would > need to be done.**** > > ** ** > > Thanks.**** > > ** ** > > -John**** > > ** ** > > ** ** > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
