+    llvm_unreachable("Unsupported ABI kind for va_arg");

Unsupported or it is impossible to get here? If it is something a user
can hit, this should probably be report_fatal_error as
llvm_unreachable will not cause clang to stop in a -Asserts build.

+// RUN: %clang -target xcore -O3

Why run the tests at -O3? We normally prefer to test clang at -O0.

LGTM with those comments addressed.


On 15 August 2013 06:52, Robert Lytton <[email protected]> wrote:
> Hi,
>
> Add target specific EmitVAArg to XCore target.
> This was so aggregates could be passed as var args too.
>
> Robert
>
> _______________________________________________
> cfe-commits mailing list
> [email protected]
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to