On 15 August 2013 10:25, Jack Carter <[email protected]> wrote: > Rafael, > > Because I want to do the right thing: > > For new inhouse Mips llvm developers the process should be: > * the initial inhouse review
I find it more convenient to do the entire review on the public lists, but this part is up to you. > * post to the list for final review > * commit by someone familiar with the code base affected > * After 5 or so decent patches, apply for commit access Correct. > For the public review process, how long does one wait without comment before > the inhouse reviews suffice and a commit can happen? Depends on the reviewer. If you are sure a particular patch is OK, just LGTM it and it is good to go. If you think someone else should review it, say that. The important point is that there is a thread where one can hit reply and talk with the original author. > Do we just post from the inhouse reviewers our acceptance (if we agree with > the post) and wait a working day? > > Is there ever a period where inhouse review will suffice? > > Cheers, > > Jack Cheers, Rafael _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
