This is not important, but when I build libcxx using a recent beta version cmake, namely this one "cmake version 2.8.11.20130809-gba97e"
I get this error now:
CMake Warning (dev) in CMakeLists.txt:
Syntax Warning in cmake code at
c:/libcxx/CMakeLists.txt:48:54
Argument not separated from preceding token by whitespace.
This warning is for project developers. Use -Wno-dev to suppress it.
The offending line 48 appears to be this:
set_property(CACHE LIBCXX_CXX_ABI PROPERTY STRINGS "";${CXXABIS})
Removing the quotes and changing the line to the line below fixes
the warning and I hope does not change the meaning?
I've yet to observe any harm from the change on my build at least.
set_property(CACHE LIBCXX_CXX_ABI PROPERTY STRINGS ;${CXXABIS})
This is all the attached patch does.
The ; is curious as to why it's needed but I do remember a problem vaguely
that I fixed in this file some time ago related to ; delimiters and maybe
CXXABIS that suggests it is necessary so I've left the ;
I mention that in case it allows anyone to recall the conversation that
will allow them to remove the ";" too. But otherwise they probably
shouldn't.
As long as "";$(X) yields the same string as ;$(x) it should be a safe
change. Hopefully a regular cmake user can verify this.
It's not a necessary fix it just removes an irritant warning that can be
supressed with a flag anyway.
cmakelists.diff
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
