Nice! LGTM too, just a few nits.
================
Comment at: include/clang/Analysis/Analyses/FormatString.h:94
@@ -90,3 +93,3 @@
unsigned getLength() const {
switch (kind) {
----------------
Looks like this needs an update too? This is used when emitting fix-it hints
for replacing a length modifier.
================
Comment at: lib/Analysis/FormatString.cpp:240
@@ +239,3 @@
+ I += 3;
+ lmKind = LengthModifier::AsInt64;
+ break;
----------------
Jordan Rose wrote:
> Typo: AsInt32.
AsInt32?
================
Comment at: lib/Analysis/FormatString.cpp:718
@@ +717,3 @@
+ case ConversionSpecifier::XArg:
+ return Target.getTriple().isOSMSVCRT();
+ default:
----------------
It would be nice to have a test for the case when isOSMSVCRT() is false.
http://llvm-reviews.chandlerc.com/D1456
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
