================
Comment at: clang-replace/ApplyReplacements.h:38
@@ +37,3 @@
+/// \brief Collection of TranslationUnitReplacement files.
+typedef std::set<std::string> TUReplacementFiles;
+
----------------
Stefanus Du Toit wrote:
> Do you really need a set here? I assume that collectReplacementsFromDirectory
> will never encounter the same file twice, so you might as well just use a
> vector and avoid the overhead of using a set.
Will change. I think I picked it up from some early uncommitted revision of the
code.
================
Comment at: clang-replace/tool/ClangReplaceMain.cpp:80
@@ -53,3 +79,3 @@
if (!applyReplacements(GroupedReplacements, SM))
return 1;
----------------
Stefanus Du Toit wrote:
> Stefanus Du Toit wrote:
> > And likewise for this. Seems to me they should only be removed if all of
> > the operations succeeded. As a bonus, then you don't need ScopedFileRemover
> > anymore!
> Actually, I guess I can see why you might want this behaviour (removing even
> if errors occurred) for something like cpp11-migrate. But I now _especially_
> think this should be a command-line option.
One command line option coming up :).
http://llvm-reviews.chandlerc.com/D1492
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
