Most of our path variables point to directories or can be relative paths, so they have type PATH. I'm not sure CLANG_ORDER_FILE can be relative, and it has to point to a file that already exists, so using FILEPATH makes sense.
On Aug 23, 2013, at 17:46 , "Edoardo P." <ed0.88.p...@gmail.com> wrote: > I was not sure about it, because with a quick search through the cmake files > I couldn't find another variable with said type. Should I still change it? > > > 2013/8/24 Jordan Rose <jordan_r...@apple.com> > Actually, it should be a FILEPATH, shouldn't it? > > On Aug 23, 2013, at 16:00 , Edoardo P. <ed0.88.p...@gmail.com> wrote: > > > Hi, > > > > I noticed that in tools/clang/CMakeLists.txt CLANG_ORDER_FILE was added, > > but it was defined with the cmake function 'option', which makes the > > variable a BOOL, which is wrong. I noticed it when I got: 'error: cannot > > open ON: No such file or directory' when linking clang executable. This > > happened because I accidentally checked the 'option' CLANG_ORDER_FILE with > > cmake-gui. Since it is a filename, it should be defined as a STRING with > > 'set'. The attached patch should fix this. > > > > Regards, > > Edward-san > > -- > > Mathematics is the language with which God has written the universe. > > (Galilei) > > > _______________________________________________ > > cfe-commits mailing list > > cfe-commits@cs.uiuc.edu > > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > > > > > -- > Mathematics is the language with which God has written the universe. (Galilei)
_______________________________________________ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
