The headers in question might be internal, but I'm not sure. I think I'll just give up on this for now unless someone chimes in otherwise, and focus on fixing the remaining issues with the existing code. This morning I checked in a couple of fixes for bogus duplicate symbol error messages. Now I'll focus on cleaning up the duplicate note messages which follow "error: header 'x.h' has different contents depending on how it was included." Message.
From: [email protected] [mailto:[email protected]] On Behalf Of Sean Silva Sent: Friday, August 23, 2013 2:43 PM To: John Thompson Cc: [email protected] Subject: Re: [PATCH] modularize - header dependencies - version 2 On Fri, Aug 23, 2013 at 3:03 PM, John Thompson <[email protected]<mailto:[email protected]>> wrote: Sean, Thanks for the feedback. Regarding the usefulness of the feature in general, my opinion is that modules don't care if headers within the module have dependencies on other headers within the module. These must be internal (i.e. not user-visible) headers that are not meant to be included on their own, so I'm not sure it even makes sense to check them on their own. What do you think? -- Sean Silva
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
