On 27 August 2013 00:54, Chandler Carruth <[email protected]> wrote:
> > On Tue, Aug 27, 2013 at 12:49 AM, Nick Lewycky <[email protected]>wrote: > >> Good catch. Foo could be a template function (or a template variable in >> C++14 I suppose) instead of a template class. That I know how to fix. >> > > Yikes, hadn't even thought of the cases when it was the wrong kind of > template-id.... > > >> Unfortunately, the template typo correction is wired into >> LookupTemplateName. Even if I bypass isTemplateName and create a >> LookupResult with diagnostics suppressed, we still get the typo >> corrections. I do not know the design of clang well enough to know how to >> change that. >> > > Yea, not saying you need to fix, saying it's worth a PR or something to > track. Maybe talk to Kaelyn so its on her or Richard's radar to look at it. > I'm imagining things like 'sorte' -> 'sort' instead of 'sort' -> 'sorter'. > Maybe I'm too worried, but I'd like to make sure we don't lose track of > this issue. > Fixed. ClassifyName doesn't do typo correction (unless you ask it to). Testcases added. Please review! Nick
pr8382-2.patch
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
