I have committed the patch with the comment reworded (thanks for catching it, sometimes i send things off too hastily). I have included a note about -fcheck-new for future reference.
cheers, pl On 27 August 2013 20:22, Arthur O'Dwyer <[email protected]> wrote: > On Tue, Aug 27, 2013 at 9:16 AM, Jordan Rose <[email protected]> wrote: >> On Aug 27, 2013, at 9:03 , Arthur O'Dwyer <[email protected]> wrote: >>> >>> I like this patch, but I think it makes it even more important that >>> Clang implement GCC's -fcheck-new semantics as soon as possible. >> >> [...] I think it's okay for this to go in unrelated to -fcheck-new > > Oh, definitely the patch should go in. I said I liked it. :) > > I'm just saying, Pavel is replacing "if !-fno-exceptions" with "if > true", when the ideally correct logic would be "if !-fcheck-new" > except that Clang hasn't implemented that flag yet. You're replacing > one approximation with another, rather than dealing with the > underlying missing functionality. (At least, that's one way of looking > at it. There are others. ;)) > > –Arthur _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
