LGTM, modulo changing naked pointers over to owned pointers in a subsequent patch.
+ splitVarStateForIfBinOp(PInfo, CurrStates, HasElse ? FalseStates :NULL); Is still missing a space between the colon and the NULL btw. ~Aaron On Wed, Aug 28, 2013 at 4:48 PM, Christian Wailes <[email protected]> wrote: > Removed the explicit numbering of the ConsumedState enum and ensured that > all conditionals compare it to an actual enum value. > > Hi delesley, dblaikie, aaron.ballman, > > http://llvm-reviews.chandlerc.com/D1501 > > CHANGE SINCE LAST DIFF > http://llvm-reviews.chandlerc.com/D1501?vs=3771&id=3874#toc > > Files: > include/clang/Analysis/Analyses/Consumed.h > lib/Analysis/Consumed.cpp > test/SemaCXX/warn-consumed-analysis-strict.cpp > test/SemaCXX/warn-consumed-analysis.cpp _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
