On Mon, Aug 26, 2013 at 6:22 PM, Aaron Ballman <[email protected]>wrote:
> This patch addresses some inconsistencies between inheritable and > non-inheritable attributes. Currently, the CUDAHost and CUDADevice > attributes are specified as inheritable in Attr.td, but processed as > NonInheritable in SemaDeclAttr.cpp. Similarly, Mode is specified as > NonInheritable in Attr.td but processed as Inheritable in > SemaDeclAttr.cpp. > > This patch makes the processing and the declaration consistent. > However, since I am not that familiar with CUDA or mode attributes, I > wanted to make sure I've not got things backwards or am > misunderstanding a design constraint. > The "Mode" attribute shouldn't be inheritable; it only applies to a particular typedef declaration, not redeclarations of it. I'm not sure about the CUDA attributes; if nobody chimes in, just do whatever seems appropriate. -Eli
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
