The diff on Phabricator generally only works if you include the full file as context (or generate it through the "arc" tool). This is probably a Phabricator bug, since the line numbers are clearly in the rich display but not through "Download Raw Diff". Can you upload the patch one more time with full context?
On Aug 30, 2013, at 10:21 , Karthik Bhat <[email protected]> wrote: > Thanks Jordan,Ted,Richard, > Could someone commit it for me as i don't have the permissions. > Thanks! > > > On Fri, Aug 30, 2013 at 10:44 PM, Ted Kremenek <[email protected]> wrote: > Looks good to me. > > On Aug 30, 2013, at 9:46 AM, Jordan Rose <[email protected]> wrote: > > > > > P.S. Please remember to add cfe-commits as a CC for patches. > > > > http://llvm-reviews.chandlerc.com/D1529 > > _______________________________________________ > > cfe-commits mailing list > > [email protected] > > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
