On Tue, Sep 3, 2013 at 1:03 PM, Aaron Ballman <[email protected]>wrote:

> The tablegen for the format attribute claims the first argument
> expected is a string.  However, the attribute actually takes an
> unresolved identifier instead of a string literal.  This patch
> clarifies that by making the attribute take an IdentifierArgument, and
> updates associated code.
>
> Since this is the only case where the parser was doing something
> special for StringArguments, I updated the tablegen emitter to remove
> complexity.
>
>
Is there any reason to not just make FormatAttr::getType() return an
IdentifierInfo?

Otherwise, looks fine.

-Eli
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to