@revane I think your refactoring is good and covers all cases. The only case
I would add is the case where nothing was provided in the command line and
generate an error.
================
Comment at: cpp11-migrate/tool/Cpp11Migrate.cpp:247-248
@@ +246,4 @@
+ !GlobalOptions.ModifiableFiles.isExcludeListEmpty())
+ for (std::vector<std::string>::iterator I = SourcePaths.begin();
+ I != SourcePaths.end();)
+ if (GlobalOptions.ModifiableFiles.isFileExplicitlyExcluded(*I)) {
----------------
Guillaume Papin wrote:
> Is this line correctly formatted?
Fixed,
================
Comment at: cpp11-migrate/tool/Cpp11Migrate.cpp:264
@@ +263,3 @@
+ std::vector<std::string> Files = Compilations->getAllFiles();
+ for (std::vector<std::string>::iterator I = Files.begin(),
+ E = Files.end();
----------------
Guillaume Papin wrote:
> const_iterator maybe?
sure
================
Comment at: cpp11-migrate/Core/IncludeExcludeInfo.cpp:160
@@ -159,3 +159,3 @@
for (std::vector<std::string>::const_iterator I = ExcludeList.begin(),
E = ExcludeList.end();
----------------
Edwin Vane wrote:
> You should replace this for loop with a call to `isFileExplicitlyExcluded()`.
I'll do
================
Comment at: cpp11-migrate/Core/IncludeExcludeInfo.h:51
@@ -50,1 +50,3 @@
+ bool isFileExplicitlyExcluded(llvm::StringRef FilePath) const;
+
----------------
Edwin Vane wrote:
> Don't forget doxygen docs for new member functions.
yes sure
http://llvm-reviews.chandlerc.com/D1517
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
