On Fri, Sep 6, 2013 at 2:50 AM, Enea Zaffanella <[email protected]>wrote:
> On 09/05/2013 10:12 PM, Eli Friedman wrote: > >> On Thu, Sep 5, 2013 at 12:34 AM, Enea Zaffanella <[email protected] >> <mailto:[email protected]**>> wrote: >> > [...] > >> To summarize, I see two options: >> >> (a) rename getParenRange() as getParenOrBraceRange(); >> >> (b) have two different methods, getParenRange() and getBraceRange(), >> to be used based on the value of a boolean flag. >> Question: is it the case that >> bool CXXConstructExpr::__**isListInitialization() >> >> is such an appropriate flag to be used here? >> >> >> Yes. >> >> I would probably opt for (b). >> Do you see a third option which is better? >> >> >> I don't really see any other options; I guess I would lean towards >> option A, and let the users branch if they care about the difference, >> but either way works. >> > > Please find attached a revised patch implementing option A. > OK to commit? > > LGTM. -Eli
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
