On 2013-09-06, at 10:12 , Tom Stellard <[email protected]> wrote: > On Fri, Sep 06, 2013 at 12:11:48PM +0200, Michele Scandale wrote: >> On 09/04/2013 05:53 PM, Erik Schnetter wrote: >>> I do not have commit rights. How do I get this patch committed? >>> >>> -erik >>> >> >> I think we have to wait that David or Tom approve this last version and >> commit it. >> >> Maybe a single patch file to apply modification and add tests respect to the >> last trunk would make easier the commit. >> > > The latest version of the patch looks good to me, but I agree, the test > cases should be included in the patch.
Apologies for the delay -- I encountered some code generation problems while testing the patch and wanted to make sure they were not caused by the patch. (It turns out these problems were caused by using different CPU types while building different object files, leading to different calling conventions. I was surprised that the ABI is not completely determined by the target triple, but that CPU attributes influence this as well... but this is unrelated to the patch here. In my case, 32-byte vectors are passed differently depending on whether AVX instructions are available.) I recreated the patch with the test cases included; attached below. -erik -- Erik Schnetter <[email protected]> http://www.perimeterinstitute.ca/personal/eschnetter/ My email is as private as my paper mail. I therefore support encrypting and signing email messages. Get my PGP key from http://pgp.mit.edu/.
OpenCL-long-trunk.diff
Description: Binary data
signature.asc
Description: Message signed with OpenPGP using GPGMail
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
