LGTM with minor change to diagnostics. This is definitely useful 
functionality.


================
Comment at: lib/Lex/ModuleMap.cpp:1310
@@ +1309,3 @@
+  if (!Tok.is(MMToken::StringLiteral)) {
+    Diags.Report(Tok.getLocation(), diag::err_mmap_expected_header) 
+      << "header";
----------------
It's a module map file name, not a header name. The diagnostic and comment are 
wrong.


http://llvm-reviews.chandlerc.com/D1637
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to