Thank you for review. Committed as r190528.

On Wed, Sep 11, 2013 at 4:21 AM, Manuel Klimek <[email protected]> wrote:

>
>   lg for the testing side, with the grammar updates :)
>
>
> ================
> Comment at: unittests/Tooling/RecursiveASTVisitorTest.cpp:158
> @@ -146,1 +157,3 @@
>
> +// Test RAV visits parameter variable declaration of implicit
> +// copy assignment operator.
> ----------------
> of *the* implicit?
>
> ================
> Comment at: unittests/Tooling/RecursiveASTVisitorTest.cpp:165
> @@ +164,3 @@
> +  // same SourceLocation with its class declaration, so we match an empty
> name
> +  // with class source location here.
> +  Visitor.ExpectMatch("", 1, 7);
> ----------------
> I'd say "with the class' source location"
>
>
> http://llvm-reviews.chandlerc.com/D958
>
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to