Thanks for the feedback! I've addressed those three issues, and the updated patch is attached.
On Fri, Sep 13, 2013 at 4:12 AM, Daniel Jasper <[email protected]> wrote: > You should be able to use "Tok.getPrecedence() == prec::Assignment" > instead of the new IsTokenAssignment function. Also, please put the tests > into "unittests/Format/FormatTest.cpp". We have plans to turn (some of) > those into file-based tests, but for now, I'd like to keep > formatting-specific tests together. Also, in addition to actually testing > whether the style-configuration works as expected, there are also tests > there which test whether the option can be successfully parsed from JSON > (see how it is done for the other flags close to the bottom). > > > On Fri, Sep 13, 2013 at 12:14 AM, Aaron Wishnick < > [email protected]> wrote: > >> My organization's coding standards include not putting a space before >> assignment operators, e.g. "int a= 42;". In order for us to be able to use >> clang-format, we need support for this. >> >> I've attached a patch that adds a new format style option, >> "SpaceBeforeAssignmentOperators." All the existing hard-coded styles now >> default to having it set to true. I've also included a test. >> >> Please let me know if this looks good, or if there's anything else I can >> do. >> >> Thank you! >> Aaron >> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >> >> >
space_before_assignment_operators.patch
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
