On Wed, Sep 25, 2013 at 9:45 AM, Mark Lacey <[email protected]> wrote: > Ping? > > The change is simple and I suspect the current value there was an oversight > from a past commit, so if there are no objections I’ll commit later today. >
We don't generally do this. Once it's out it is generally considered polite to wait for review especially since a large number of the C++ people are at the committee meeting this week. That said two attributes were merged to one in r176164 and the bitfield wasn't updated so LGTM. -eric > Mark > > On Sep 24, 2013, at 1:40 PM, Mark Lacey <[email protected]> wrote: > >> I noticed this while reading code. Can someone take a look to verify that I >> am not misunderstanding something here, and that my math is not off? >> >> Passes ‘check-all’ and test-suite. >> >> Mark >> >> --- >> include/clang/AST/Type.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> <0001-Update-NumTypeBits-on-Type-to-match-the-actual-numbe.patch>_______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
