On Thu, Sep 26, 2013 at 1:57 PM, Marshall Clow <[email protected]>wrote:
> While discussing the status of <strstream> in C++14, I decided to search > through the LLVM/clang code base for uses of strstream. > > I didn't find any, just a header file that includes <strstream>. > > Here's a patch that removes that. This should (marginally) speed up builds. > I don't see in that in your patch. I do see this: Index: INPUTS/all-std-headers.cpp =================================================================== --- INPUTS/all-std-headers.cpp (revision 191429) +++ INPUTS/all-std-headers.cpp (working copy) @@ -44,9 +44,9 @@ #include <stdexcept> #include <streambuf> #include <string> -#if __has_include(<strstream>) -#include <strstream> -#endif +// #if __has_include(<strstream>) +// #include <strstream> +// #endif #include <typeinfo> #include <utility> #include <valarray> Please don't apply this part. We want to be able to test that Clang succeeds at parsing all headers in the standard library, so if it has strstream, we should test it. And we want to benchmark it, for the same reasons. This file isn't actually part of any build anyways. > > Also, I removed a mention of <strstream> from a test for "has_header" - I > used <new> instead. > This is fine. > > -- Marshall > > Marshall Clow Idio Software <mailto:[email protected]> > > A.D. 1517: Martin Luther nails his 95 Theses to the church door and is > promptly moderated down to (-1, Flamebait). > -- Yu Suzuki > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
