One patch per bullet point in the original patch's commit message seems to be the most logical thing to me.
-- Sean Silva On Fri, Sep 27, 2013 at 12:24 AM, Justin Bogner <[email protected]>wrote: > Sean Silva <[email protected]> writes: > > I replied to your first ping on Jul 22; this patch doesn't seem to > address my > > comments ("Please split this into separate commits for each logical > change") > > I missed that message somehow. Sorry about that. How's two commits > sound, ie: > > - Remove the note about Identifiers used for C++ operators > - Document CXXLiteralOperatorName and CXXUsingDirective > > or would you consider the two new DeclarationNames to be different > logical changes as well? >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
