Jiangning, In the clang changes, some of the intrinsics name carry a 'q' at the end of the base function name ( e..g., vmla_laneq). As a consequence you have to define a Q and non-Q version of the intrinsic declaration.
Do you think it is better to add the 'q' using a size modifier like "128b but mangling 'q' at the end of base neon function name". I did something like that for the scalar by element intrinsics where I need to generate names like 'vmulxd_laneq_f64'. But in your case it seems you need 'q' both before the first '_' and at the end of the base neon function name. Is that the reason you did not use a type modifier? You would need yet another size modifier like '128b but mangling 'q' at both places". It would be best if we agree on a common way to handle the 'q' at the end of base neon function name. Thanks, Ana. -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Jiangning Liu Sent: Tuesday, October 01, 2013 6:42 AM To: [email protected]; [email protected] Cc: [email protected]; [email protected] Subject: Re: [PATCH] Implement aarch64 neon instruction class AdvSIMD (by element) - Clang Hi t.p.northover, http://llvm-reviews.chandlerc.com/D1752 CHANGE SINCE LAST DIFF http://llvm-reviews.chandlerc.com/D1752?vs=4545&id=4577#toc Files: include/clang/Basic/arm_neon.td lib/CodeGen/CGBuiltin.cpp test/CodeGen/aarch64-neon-2velem.c utils/TableGen/NeonEmitter.cpp _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
