On Oct 1, 2013, at 10:12 , Jordan Rose <[email protected]> wrote:

> 
> On Oct 1, 2013, at 9:08 , Rafael Espíndola <[email protected]> wrote:
> 
>> On 1 October 2013 11:56, Jordan Rose <[email protected]> wrote:
>>> Ah. The idea is that the version at least gets updated when you 
>>> reconfigure, but that's already there by removing the output file.
>>> 
>>> Please don't remove HAVE_SVN_VERSION_INC, though. A slightly outdated 
>>> version is still better than no version at all.
>> 
>> Cmake deletes the file (on reconfigure?) since it is marked as
>> generated. If the dependency to clang_revision_tag is not there and we
>> keep HAVE_SVN_VERSION_INC defined the build fails.
> 
> Okay...I think we just have problems here. Please revert my original patch 
> and I'll come up with something that doesn't affect null builds by default, 
> but still provides the best version information it can.

LLVM-side: r190556, r190808
Clang-side: r190557
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to