Submitted as r191820.

I absolutely agree that tests would be nice, but I have not gotten around
to writing them yet (and probably won't for several more weeks) :-(.

Thanks for working on this!


On Wed, Oct 2, 2013 at 11:14 AM, Alp Toker <[email protected]> wrote:

> clang-format-diff incorrectly modifies unchanged lines due to an error
> in diff parsing.
>
> The unified diff format has a default line change count of 1, and 0 may
> be specified to indicate that no lines have been added. This patch
> updates the parser to accurately reflect the diff specification.
>
> This also has the benefit of stabilising the operation so it will
> produce the same output when run multiple times on the same changeset,
> which was previously not the case.
>
> No tests added because this script is not currently tested (though we
> should look into that!)
>
> --
> http://www.nuanti.com
> the browser experts
>
>
> _______________________________________________
> cfe-commits mailing list
> [email protected]
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to