Hi Jiangning,

  Ana's probably the expert on the NEONEmitter, though I didn't see anything 
obviously wrong. Just one other comment.

  Cheers.

  Tim.


================
Comment at: lib/CodeGen/CGBuiltin.cpp:1958
@@ +1957,3 @@
+      Ops.push_back(CGF.EmitScalarExpr(E->getArg(i)));
+    }
+  }
----------------
Couldn't this block be:

    if (AcrossVec) {
      ...
    } else if (OverloadInt) {
      ...
    } else
      ...

    for(...) Ops.push_back(...)


http://llvm-reviews.chandlerc.com/D1817
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to