Adding these should come after checking IgnoredOptionMap since some options
need to be ignored.
# Ignored options.
if (defined $IgnoredOptionMap{$ArgKey}) {
my $Cnt = $IgnoredOptionMap{$ArgKey};
while ($Cnt > 0) {
++$i; --$Cnt;
}
next;
}
Also, I would have thought that the following would add the valid -f options to
the command line. Why that does not work?
if ($Arg =~ /^-f/) {
push @CompileOpts,$Arg;
push @LinkOpts,$Arg;
next;
}
Thanks,
Anna.
On Oct 1, 2013, at 11:32 PM, Liang Qi <[email protected]> wrote:
> Hi,
>
> This change whitelists -fXXXX options. At least the use case here is to pass
> -fPIE and -fPIC to compiler, more talks in
> https://bugreports.qt-project.org/browse/QTBUG-33698 .
>
> Review appreciated.
>
> Regards,
> Liang
>
> http://llvm-reviews.chandlerc.com/D1805
>
> Files:
> tools/scan-build/ccc-analyzer
>
> Index: tools/scan-build/ccc-analyzer
> ===================================================================
> --- tools/scan-build/ccc-analyzer
> +++ tools/scan-build/ccc-analyzer
> @@ -488,6 +488,10 @@
> push @CompileOpts,$Arg;
> next;
> }
> + if ($Arg =~ /-f.*/) {
> + push @CompileOpts,$Arg;
> + next;
> + }
> # Handle the case where there isn't a space after -iquote
> if ($Arg =~ /-iquote.*/) {
> push @CompileOpts,$Arg;
>
>
> _______________________________________________
> cfe-commits mailing list
> [email protected]
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
