Author: hhinnant
Date: Fri Oct 4 19:07:35 2013
New Revision: 192010
URL: http://llvm.org/viewvc/llvm-project?rev=192010&view=rev
Log:
G M: Attached is a patch for libcxx's cmake file.
I've changed it so we don't set highest level warnings (all) for MSVC when
building projects using cmake and instead leave the default. That's /W4 on my
machine and seems to be ok.
With all warnings on for msvc, we see literally thousands of warnings. 99.99%
aren't relevant and just obscure the ones that are.
I think the user can still override things if they want something different
from the command line when using cmake.
Modified:
libcxx/trunk/CMakeLists.txt
Modified: libcxx/trunk/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk/CMakeLists.txt?rev=192010&r1=192009&r2=192010&view=diff
==============================================================================
--- libcxx/trunk/CMakeLists.txt (original)
+++ libcxx/trunk/CMakeLists.txt Fri Oct 4 19:07:35 2013
@@ -185,7 +185,9 @@ macro(append_if list condition var)
endmacro()
# Get warning flags
-append_if(LIBCXX_CXX_WARNING_FLAGS LIBCXX_HAS_WALL_FLAG -Wall)
+if (NOT MSVC)
+ append_if(LIBCXX_CXX_WARNING_FLAGS LIBCXX_HAS_WALL_FLAG -Wall)
+endif()
append_if(LIBCXX_CXX_WARNING_FLAGS LIBCXX_HAS_W_FLAG -W)
append_if(LIBCXX_CXX_WARNING_FLAGS LIBCXX_HAS_WNO_UNUSED_PARAMETER_FLAG
-Wno-unused-parameter)
append_if(LIBCXX_CXX_WARNING_FLAGS LIBCXX_HAS_WWRITE_STRINGS_FLAG
-Wwrite-strings)
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
